Show left and right hand values when equality fails
For assertions that contain function calls, displaying just the
expression is not helpful. For e.g.
Assertion failed
String.upcase("foo") == "Foo"
The learner is given no extra information to help them learn. Sure they
might consult the documentation (and should!), but perhaps a better
experience would be for us to inform the learner about the values it
encountered.
Assertion failed
String.upcase("foo") == "Foo"
left: "FOO"
right: "Foo"
Learner: 💡 ah hah! it upcases the whole string! 💫
This commit is contained in:
@@ -2,6 +2,7 @@ defmodule Display.Paint do
|
|||||||
def red(str), do: painter().red(str)
|
def red(str), do: painter().red(str)
|
||||||
def cyan(str), do: painter().cyan(str)
|
def cyan(str), do: painter().cyan(str)
|
||||||
def green(str), do: painter().green(str)
|
def green(str), do: painter().green(str)
|
||||||
|
def yellow(str), do: painter.yellow(str)
|
||||||
|
|
||||||
defp painter do
|
defp painter do
|
||||||
case Mix.env do
|
case Mix.env do
|
||||||
@@ -17,6 +18,7 @@ defmodule Display.Colours do
|
|||||||
def red(str), do: colourize(ANSI.red, str)
|
def red(str), do: colourize(ANSI.red, str)
|
||||||
def cyan(str), do: colourize(ANSI.cyan, str)
|
def cyan(str), do: colourize(ANSI.cyan, str)
|
||||||
def green(str), do: colourize(ANSI.green, str)
|
def green(str), do: colourize(ANSI.green, str)
|
||||||
|
def yellow(str), do: colourize(ANSI.yellow, str)
|
||||||
|
|
||||||
defp colourize(color, message) do
|
defp colourize(color, message) do
|
||||||
Enum.join([color, message, ANSI.reset], "")
|
Enum.join([color, message, ANSI.reset], "")
|
||||||
|
|||||||
@@ -9,11 +9,12 @@ defmodule Display.Failure do
|
|||||||
#{Paint.red(message)}
|
#{Paint.red(message)}
|
||||||
"""
|
"""
|
||||||
end
|
end
|
||||||
def format_failure(%{error: %ExUnit.AssertionError{expr: expr}, file: file, line: line}) do
|
def format_failure(%{error: %ExUnit.AssertionError{expr: expr} = error, file: file, line: line}) do
|
||||||
"""
|
"""
|
||||||
#{Paint.cyan("Assertion failed in #{file}:#{line}")}
|
#{Paint.cyan("Assertion failed in #{file}:#{line}")}
|
||||||
#{Paint.red(Macro.to_string(expr))}
|
#{Paint.red(Macro.to_string(expr))}
|
||||||
"""
|
"""
|
||||||
|
|> format_inequality(error)
|
||||||
end
|
end
|
||||||
def format_failure(%{error: error, file: file, line: line}) do
|
def format_failure(%{error: error, file: file, line: line}) do
|
||||||
"""
|
"""
|
||||||
@@ -22,6 +23,17 @@ defmodule Display.Failure do
|
|||||||
"""
|
"""
|
||||||
end
|
end
|
||||||
|
|
||||||
|
defp format_inequality(message, %{left: @no_value, right: @no_value}) do
|
||||||
|
message
|
||||||
|
end
|
||||||
|
defp format_inequality(message, %{left: left, right: right}) do
|
||||||
|
"""
|
||||||
|
#{message}
|
||||||
|
left: #{left |> inspect |> Paint.yellow}
|
||||||
|
right: #{right |> inspect |> Paint.yellow}
|
||||||
|
"""
|
||||||
|
end
|
||||||
|
|
||||||
defp format_error(error) do
|
defp format_error(error) do
|
||||||
trace = System.stacktrace |> Enum.take(2)
|
trace = System.stacktrace |> Enum.take(2)
|
||||||
Paint.red(Exception.format(:error, error, trace))
|
Paint.red(Exception.format(:error, error, trace))
|
||||||
|
|||||||
Reference in New Issue
Block a user